perf: upgrade Grit and remove im crate
#4232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
approved these changes
Oct 10, 2024
CodSpeed Performance ReportMerging #4232 will improve performances by 19.33%Comparing Summary
Benchmarks breakdown
|
arendjr
added a commit
to arendjr/biome
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades Grit crates to 0.4. Main difference is a change I made to remove the
imcrate as a dependency entirely. This resulted in a rougly 25-30% performance improvement in our Grit benchmarks, at least locally.Another nice effect is that our
biome_grit_patternscrate no longer depends onanyhow, though other Biome crates still do.Test Plan
CI should remain green.